TonBERRY/micropython
3
0
Fork 0
Code Pull Requests Activity

py/objmodule: Add a table of built-in modules with delegation.

Browse Source 
This replaces the previous QSTR_null entry in the globals dict which could
leak out to Python (e.g. via iteration of mod.__dict__) and could lead to
crashes.

It results in smaller code size at the expense of turning a lookup into a
loop, but the list it is looping over likely only contains one or two
elements.

To allow a module to register its custom attr function it can use the new
`MP_REGISTER_MODULE_DELEGATION` macro.

This work was funded through GitHub Sponsors.

Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
This commit is contained in:
Jim Mussared
2023-06-05 15:52:57 +10:00
parent eb85f4d4c9
commit 13c817e61c
9 changed files with 67 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
py/builtinhelp.c
View File

@@ -151,12 +151,7 @@ STATIC void mp_help_print_obj(const mp_obj_t obj) {
if (map != NULL) {
for (uint i = 0; i < map->alloc; i++) {
mp_obj_t key = map->table[i].key;
if (key != MP_OBJ_NULL
#if MICROPY_MODULE_ATTR_DELEGATION
// MP_MODULE_ATTR_DELEGATION_ENTRY entries have MP_QSTRnull as qstr key.
&& key != MP_OBJ_NEW_QSTR(MP_QSTRnull)
#endif
) {
if (key != MP_OBJ_NULL) {
mp_help_print_info_about_object(key, map->table[i].value);
}
}