From 6f0193335af497c4e14d67c4224f8e35d3755ba8 Mon Sep 17 00:00:00 2001 From: Sebastian Romero Date: Thu, 9 Nov 2023 11:21:00 +0100 Subject: [PATCH] ports: Fix incorrect identifiers on Arduino boards. This commit changes the Arduino board identifiers to correspond to their official names. This helps to identify boards at runtime. At the moment the Arduino Portenta H7 is reported as PORTENTA which is unfortunate as now there is another Portenta board (Portenta C33) supported in MicroPython. Also made the other identifiers for flash and network name consistent, removed the incorrectly used MICROPY_PY_SYS_PLATFORM identifiers, and added missing MICROPY_PY_NETWORK_HOSTNAME_DEFAULT identifiers. Boards affected: - stm32: ARDUINO_PORTENTA_H7, ARDUINO_GIGA, ARDUINO_NICLA_VISION - renesas-ra: ARDUINO_PORTENTA_C33 - esp32: ARDUINO_NANO_ESP32 - rp2: ARDUINO_NANO_RP2040_CONNECT Signed-off-by: Sebastian Romero --- ports/esp32/boards/ARDUINO_NANO_ESP32/mpconfigboard.h | 3 +++ .../boards/ARDUINO_PORTENTA_C33/mpconfigboard.h | 6 +++++- .../boards/ARDUINO_NANO_RP2040_CONNECT/mpconfigboard.h | 3 +++ ports/stm32/boards/ARDUINO_GIGA/mpconfigboard.h | 8 +++++--- ports/stm32/boards/ARDUINO_NICLA_VISION/mpconfigboard.h | 8 +++++--- ports/stm32/boards/ARDUINO_PORTENTA_H7/mpconfigboard.h | 8 ++++---- 6 files changed, 25 insertions(+), 11 deletions(-) diff --git a/ports/esp32/boards/ARDUINO_NANO_ESP32/mpconfigboard.h b/ports/esp32/boards/ARDUINO_NANO_ESP32/mpconfigboard.h index 3e98bb99d..ec85a7bb3 100644 --- a/ports/esp32/boards/ARDUINO_NANO_ESP32/mpconfigboard.h +++ b/ports/esp32/boards/ARDUINO_NANO_ESP32/mpconfigboard.h @@ -1,6 +1,9 @@ #define MICROPY_HW_BOARD_NAME "Arduino Nano ESP32" #define MICROPY_HW_MCU_NAME "ESP32S3" +// Network config +#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "mpy-nano-esp32" + #define MICROPY_PY_MACHINE_DAC (0) #define MICROPY_HW_I2C0_SCL (12) diff --git a/ports/renesas-ra/boards/ARDUINO_PORTENTA_C33/mpconfigboard.h b/ports/renesas-ra/boards/ARDUINO_PORTENTA_C33/mpconfigboard.h index aa1e28ab9..da452f687 100644 --- a/ports/renesas-ra/boards/ARDUINO_PORTENTA_C33/mpconfigboard.h +++ b/ports/renesas-ra/boards/ARDUINO_PORTENTA_C33/mpconfigboard.h @@ -5,10 +5,14 @@ */ // MCU config -#define MICROPY_HW_BOARD_NAME "PORTENTA C33" +#define MICROPY_HW_BOARD_NAME "Arduino Portenta C33" #define MICROPY_HW_MCU_NAME "RA6M5" #define MICROPY_HW_MCU_SYSCLK 200000000 #define MICROPY_HW_MCU_PCLK 100000000 +#define MICROPY_HW_FLASH_FS_LABEL "Portenta C33" + +// Network config +#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "mpy-portenta-c33" // module config #define MICROPY_EMIT_THUMB (1) diff --git a/ports/rp2/boards/ARDUINO_NANO_RP2040_CONNECT/mpconfigboard.h b/ports/rp2/boards/ARDUINO_NANO_RP2040_CONNECT/mpconfigboard.h index 537c6d705..b969341a7 100644 --- a/ports/rp2/boards/ARDUINO_NANO_RP2040_CONNECT/mpconfigboard.h +++ b/ports/rp2/boards/ARDUINO_NANO_RP2040_CONNECT/mpconfigboard.h @@ -4,6 +4,9 @@ #define MICROPY_HW_BOARD_NAME "Arduino Nano RP2040 Connect" #define MICROPY_HW_FLASH_STORAGE_BYTES (8 * 1024 * 1024) +// Network config +#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "mpy-nano-rp2040-connect" + // Enable networking. #define MICROPY_PY_NETWORK (1) diff --git a/ports/stm32/boards/ARDUINO_GIGA/mpconfigboard.h b/ports/stm32/boards/ARDUINO_GIGA/mpconfigboard.h index ec9bbed5e..b278fa005 100644 --- a/ports/stm32/boards/ARDUINO_GIGA/mpconfigboard.h +++ b/ports/stm32/boards/ARDUINO_GIGA/mpconfigboard.h @@ -4,10 +4,12 @@ * Copyright (c) 2023 Arduino SA */ -#define MICROPY_HW_BOARD_NAME "GIGA" +#define MICROPY_HW_BOARD_NAME "Arduino GIGA R1 WiFi" #define MICROPY_HW_MCU_NAME "STM32H747" -#define MICROPY_PY_SYS_PLATFORM "Giga" -#define MICROPY_HW_FLASH_FS_LABEL "Giga" +#define MICROPY_HW_FLASH_FS_LABEL "GIGA R1 WiFi" + +// Network config +#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "mpy-giga-r1-wifi" #define MICROPY_OBJ_REPR (MICROPY_OBJ_REPR_C) #define UINT_FMT "%u" diff --git a/ports/stm32/boards/ARDUINO_NICLA_VISION/mpconfigboard.h b/ports/stm32/boards/ARDUINO_NICLA_VISION/mpconfigboard.h index 3cae9b25f..3a2def4d4 100644 --- a/ports/stm32/boards/ARDUINO_NICLA_VISION/mpconfigboard.h +++ b/ports/stm32/boards/ARDUINO_NICLA_VISION/mpconfigboard.h @@ -4,10 +4,12 @@ * Copyright (c) 2023 Arduino SA */ -#define MICROPY_HW_BOARD_NAME "NICLAVISION" +#define MICROPY_HW_BOARD_NAME "Arduino Nicla Vision" #define MICROPY_HW_MCU_NAME "STM32H747" -#define MICROPY_PY_SYS_PLATFORM "Nicla Vision" -#define MICROPY_HW_FLASH_FS_LABEL "niclavision" +#define MICROPY_HW_FLASH_FS_LABEL "Nicla Vision" + +// Network config +#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "mpy-nicla-vision" #define MICROPY_OBJ_REPR (MICROPY_OBJ_REPR_C) #define UINT_FMT "%u" diff --git a/ports/stm32/boards/ARDUINO_PORTENTA_H7/mpconfigboard.h b/ports/stm32/boards/ARDUINO_PORTENTA_H7/mpconfigboard.h index 133158c60..e2e6956a4 100644 --- a/ports/stm32/boards/ARDUINO_PORTENTA_H7/mpconfigboard.h +++ b/ports/stm32/boards/ARDUINO_PORTENTA_H7/mpconfigboard.h @@ -4,12 +4,12 @@ * Copyright (c) 2022 Arduino SA */ -#define MICROPY_HW_BOARD_NAME "PORTENTA" +#define MICROPY_HW_BOARD_NAME "Arduino Portenta H7" #define MICROPY_HW_MCU_NAME "STM32H747" -#define MICROPY_PY_SYS_PLATFORM "Portenta" -#define MICROPY_HW_FLASH_FS_LABEL "portenta" +#define MICROPY_HW_FLASH_FS_LABEL "Portenta H7" -#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "Portenta" +// Network config +#define MICROPY_PY_NETWORK_HOSTNAME_DEFAULT "mpy-portenta-h7" #define MICROPY_OBJ_REPR (MICROPY_OBJ_REPR_C) #define UINT_FMT "%u"