webassembly/proxy_c: Return undefined if dict lookup failed on JS side.
Instead of raising KeyError. These semantics match JavaScript behaviour
and make it much more seamless to pass Python dicts through to JavaScript
as though they were JavaScript {} objects.
Signed-off-by: Damien George <damien@micropython.org>
This commit is contained in:
34
tests/ports/webassembly/py_proxy_dict_undefined.mjs
Normal file
34
tests/ports/webassembly/py_proxy_dict_undefined.mjs
Normal file
@@ -0,0 +1,34 @@
|
||||
// Test passing a Python dict into JavaScript, how it behaves with undefined keys.
|
||||
// If JavaScript accesses a key that does not exist, `undefined` should be returned.
|
||||
// This is different to Python-side behaviour, where `KeyError` is raised.
|
||||
|
||||
const mp = await (await import(process.argv[2])).loadMicroPython();
|
||||
|
||||
// Create a JavaScript function with default arguments.
|
||||
// When `value` is `undefined` it will receive its default.
|
||||
function withDefault({ value = "OK" } = {}) {
|
||||
console.log(value);
|
||||
}
|
||||
|
||||
globalThis.withDefault = withDefault;
|
||||
|
||||
// Call the function from JavaScript with various arguments.
|
||||
withDefault();
|
||||
withDefault({});
|
||||
withDefault({ value: null });
|
||||
withDefault({ value: undefined });
|
||||
withDefault({ value: () => {} });
|
||||
|
||||
console.log("====");
|
||||
|
||||
// Call the function from Python with the same arguments as above.
|
||||
// The results should be the same.
|
||||
mp.runPython(`
|
||||
import js
|
||||
|
||||
js.withDefault()
|
||||
js.withDefault({})
|
||||
js.withDefault({"value": None})
|
||||
js.withDefault({"value": js.undefined})
|
||||
js.withDefault({"value": (lambda: {})})
|
||||
`);
|
||||
11
tests/ports/webassembly/py_proxy_dict_undefined.mjs.exp
Normal file
11
tests/ports/webassembly/py_proxy_dict_undefined.mjs.exp
Normal file
@@ -0,0 +1,11 @@
|
||||
OK
|
||||
OK
|
||||
null
|
||||
OK
|
||||
[Function: value]
|
||||
====
|
||||
OK
|
||||
OK
|
||||
null
|
||||
OK
|
||||
[Function: obj] { _ref: 7 }
|
||||
Reference in New Issue
Block a user