nfc-mp3-demo #19

Merged

matthias merged 9 commits from nfc-mp3-demo into main 2025-05-27 18:48:43 +00:00

Conversation 1 Commits 9 Files Changed 12 +430 -104

matthias commented 2025-05-20 19:17:48 +00:00

Owner

Copy Link

NFC + MP3 player demo according to the architecture

NFC + MP3 player demo according to the architecture

matthias self-assigned this 2025-05-20 19:17:48 +00:00

matthias added 9 commits 2025-05-20 19:17:49 +00:00

nfc: Add tag change notification callback 7e638fc525

Add basic application for playback based on NFC tags ... 4daf07b223

Copy and clean up test.py to main.py. Add app module (currently on
app.py, maybe make it a directory later) for application classes.

Implement app.TimerManager to allow scheduling of delayed events in the
micropython async framework.

Implement app.TagPlaybackManager which handles playing back MP3 files
based on the NFC tag reader. Currently, simply plays all MP3 files in a
folder, for which the folder name matches the tag id, in order. Resume,
random and other features not yet supported.

Use context managers to ensure deinit of audiocore and sd b56068e2f1

Add initial button handling ca78a731b4

wip: New architecture ... 6adaf508a4

Change PlayerApp to new architecture
 - depedencies injected via named tuple
 - some initial type checking
 - move on button press logic to PlayerApp

TODO: Adapt MP3 player

build: Copy python files to staging dir for littlefs af9b5fa397

Turn TimerManager into a Singleton d4245a9948

app: Implement volume curve ... 54b1077b96

TODO: Change table to correct decibel logarithm

Move playlist handling from mp3player to app ... 10188ac0cb

This completes the move of the nfc-mp3-demo to the new architecture.

matthias requested review from stefank 2025-05-20 19:17:50 +00:00

matthias force-pushed nfc-mp3-demo from 10188ac0cb to ce02daad3a 2025-05-20 20:05:17 +00:00 Compare

stefank approved these changes 2025-05-27 18:14:49 +00:00

stefank left a comment

Member

Copy Link

Quite large PR, but coherent. There is not much to say, except for thinking of possible future variation points for other downstream developers. People might want to add more buttons, register button sequences, etc in the future, and we could already consider this in future architecture discussions.

Quite large PR, but coherent. There is not much to say, except for thinking of possible future variation points for other downstream developers. People might want to add more buttons, register button sequences, etc in the future, and we could already consider this in future architecture discussions.

matthias merged commit 9059da1a70 into main 2025-05-27 18:48:43 +00:00

matthias deleted branch nfc-mp3-demo 2025-05-27 18:48:44 +00:00

matthias referenced this issue from a commit 2025-05-27 18:48:45 +00:00

Merge pull request 'nfc-mp3-demo' (#19) from nfc-mp3-demo into main

Sign in to join this conversation.

Reviewers

No Reviewers

stefank

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

flomue matthias stefank

No Assignees matthias

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: TonBERRY/tonberry-pico#19