TonBERRY/tonberry-pico
3
0
Fork 0
Code Issues 12 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

fix-interrupt-race #45

Merged
matthias merged 2 commits from fix-interrupt-race into main 2025-10-30 16:52:26 +00:00
Conversation 2 Commits 2 Files Changed 2 +26 -12
matthias commented 2025-10-27 20:29:42 +00:00
Owner
Copy Link

Fix two wait-for-interrupt race windows using the pattern from 6f155ebb55 ("audiocore: Fix small race window in get_fifo_read_value_blocking").

Fix two wait-for-interrupt race windows using the pattern from 6f155ebb5516 ("audiocore: Fix small race window in get_fifo_read_value_blocking").
matthias self-assigned this 2025-10-27 20:29:42 +00:00
matthias added 2 commits 2025-10-27 20:29:43 +00:00
rp2_sd: Fix race window in sd_spi_wait_complete 2a4033d3ca 
Similar to the fix in 6f155ebb55 ("audiocore: Fix small race window in
get_fifo_read_value_blocking"), a race and deadlock is possible when
calling __wfi with interrupts enabled. Fix it in sd_spi_wait_complete by
copying the fix from the above commit.

Signed-off-by: Matthias Blankertz <matthias@blankertz.org>
audiocore: Fix race window in i2s_stop
All checks were successful
Build RPi Pico firmware image / Build-Firmware (push) Successful in 3m23s
Details
Check code formatting / Check-C-Format (push) Successful in 7s
Details
Check code formatting / Check-Python-Flake8 (push) Successful in 10s
Details
Check code formatting / Check-Bash-Shellcheck (push) Successful in 4s
Details
Run unit tests on host / Run-Unit-Tests (push) Successful in 8s
Details
Run pytests / Check-Pytest (push) Successful in 10s
Details
23d5b050dc 
Apply the same pattern as in 6f155ebb55 ("audiocore: Fix small race
window in get_fifo_read_value_blocking") and 2a4033d3ca ("rp2_sd: Fix
race window in sd_spi_wait_complete") to the wait for interrupt in
i2s_stop too.

Signed-off-by: Matthias Blankertz <matthias@blankertz.org>
matthias requested review from Members 2025-10-27 20:29:43 +00:00
stefank approved these changes 2025-10-29 15:41:58 +00:00
stefank left a comment
Member
Copy Link

Looks legit. Did we ever see this happen?

Looks legit. Did we ever see this happen?
matthias commented 2025-10-29 16:32:45 +00:00
Author
Owner
Copy Link

Looks legit. Did we ever see this happen?

I encountered the sd_spi_wait_complete race. The i2s_stop race is theoretical, but I just decided to apply the same pattern to all __wfi users at this point.

> Looks legit. Did we ever see this happen? > I encountered the sd_spi_wait_complete race. The i2s_stop race is theoretical, but I just decided to apply the same pattern to all __wfi users at this point.
matthias merged commit a81952fb8a into main 2025-10-30 16:52:26 +00:00
matthias deleted branch fix-interrupt-race 2025-10-30 16:52:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
stefank
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
flomue matthias stefank
No Assignees matthias
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TonBERRY/tonberry-pico#45
Delete Branch "fix-interrupt-race"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?